-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loss Mean Squared Logarithmic error. #95
Conversation
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
==========================================
+ Coverage 71.27% 71.53% +0.26%
==========================================
Files 91 93 +2
Lines 4055 4100 +45
==========================================
+ Hits 2890 2933 +43
- Misses 1165 1167 +2
Continue to review full report at Codecov.
|
Hi, @charlielito please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good!
Only one thing, from now on we are making the tests also comparing with tensorflow's implementation like in this test: https://github.com/poets-ai/elegy/blob/master/elegy/losses/binary_crossentropy_test.py#L36
Also we made today some changes to the auto docs, please run again bash scripts/run-docs.sh
Hy, @charlielito I've done all the changes suggested by you. Would you please review again. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added loss
Added test cases
Formatted the code with black
Added the documention