-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build issue in trunk with pcl_visualization #80
Comments
Can you tell us how we could replicate this please? |
This is probably due to the fact that geometry is a header only module that doesn't produce a binary library file. |
So apparently we don't handle the case where library is headers only for the generated pc files though we do it for the cmake. |
@rbrusu I found a solution but I am not sure we want it pulled right now on PCL. |
@nizar-sallem The branch is not on Github anymore, do you have some fix lying around? |
For now the workaround we are using to get our pkg-config based build going is we manually create the file pcl_geometry-1.7.pc with these contents: missing pkg-config file for pcl_geometryprefix=/usr/local You can then put that somewhere in the pkg-config search path, like /usr/local/lib/pkgconfig/. Though to avoid hacking up your system you can just keep the file local to your project build directory and use this command in place of the vanilla pkg-config call in your makefiles: PKG_CONFIG_PATH=$PKG_CONFIG_PATH:. pkg-config |
I ran into the same issue and fixed it this way so that the proper pkg-config file will always be built when you build from source: I create a new macro in pcl_targets.cmake:
I also added a file: pkgconfig-headeronly.cmake.in to the same directory. It looks like this:
Then I called PCL_MAKE_PKGCONFIG_HEADER_ONLY from geometry/CMakeLists.txt. Works like a charm! |
Great, that sounds like a fix that could be included in pcl to resolve this issue, not just a workaround. Thanks! |
@jdt141 looking good, can you send it as a pull request, so we can merge it? Thanks! |
+1 for a pull request. |
Just submitted the request. HTH! |
merged, thanks! |
When linking an application that uses master PCL, I get an error due to pcl_visualization not finding pcl_geometry-1.7 :
I think this is due to commit 10d42e9 which disable the generation of the pcl_geometry-1.7.pc pkgconfig file.
Since pcl_visualization still depends on pcl_geometry, the pcl_visualization-1.7.pc file contain a reference to the non-existing pcl_geometry-1.7.pc
The text was updated successfully, but these errors were encountered: