Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix websocket case study and FactClient. #639

Merged
merged 3 commits into from
Jul 8, 2021
Merged

Fix websocket case study and FactClient. #639

merged 3 commits into from
Jul 8, 2021

Conversation

mbrandonw
Copy link
Member

Two small things I found while testing some of the new case path stuff:

  • The web socket case study has an effect that needs to a .recieve(on:)
  • The failing FactClient should be wrapped in #if DEBUG.

@mbrandonw @stephencelis
Update Examples/CaseStudies/SwiftUICaseStudies/FactClient.swift
b5f12c0 
Co-authored-by: Stephen Celis <stephen@stephencelis.com>
@mbrandonw mbrandonw merged commit 50dc37e into main Jul 8, 2021
@mbrandonw mbrandonw deleted the case-study-fixes branch July 8, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephencelis stephencelis stephencelis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbrandonw @stephencelis