Add read-only elements getter to IdentifiedArray
#12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now there was no public API to efficiently return the elements
from the underlying storage of `IdentifiedArray` as an `[Element]`,
requiring an `O(n)` `map { $0 }` via `Collection` to achieve this.
By taking advantage of the existing `O(1)` `OrderedDictionary.values`
and `OrderedDictionary.Values.elements` getters, we can efficiently
provide an `O(1)` read-only view of the elements in a more ergonomic
way.
## Changes
- Add new read-only `elements` getter to `IdentifiedArray`.
stephencelis
approved these changes
Jul 19, 2021
mgray88
pushed a commit
to TakeoutCentral/swift-identified-collections
that referenced
this pull request
Aug 26, 2021
Until now there was no public API to efficiently return the elements
from the underlying storage of `IdentifiedArray` as an `[Element]`,
requiring an `O(n)` `map { $0 }` via `Collection` to achieve this.
By taking advantage of the existing `O(1)` `OrderedDictionary.values`
and `OrderedDictionary.Values.elements` getters, we can efficiently
provide an `O(1)` read-only view of the elements in a more ergonomic
way.
## Changes
- Add new read-only `elements` getter to `IdentifiedArray`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now there was no public API to efficiently return the elements from the underlying storage of
IdentifiedArrayas an[Element], requiring anO(n)map { $0 }viaCollectionto achieve this.By taking advantage of the existing
O(1)OrderedDictionary.valuesandOrderedDictionary.Values.elementsgetters, we can efficiently provide anO(1)read-only view of the elements in a more ergonomic way.Changes
elementsgetter toIdentifiedArray.