Fix compiler failure in Xcode 11 #22
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some unknown reason (at least to me) the `subscript(position:)` extension on `MutableCollection` where `Index == Int` was causing the compilation to fail with a weird `DESERIALIZATION FAILURE` error, as mentioned on pointfreeco#15. Updating the `subscript` to use `C.Index` instead of `Int` appears to make the compiler happy and successfully compile the project. My suspicion is that it somehow enables it to disambiguate between the multiple `subscript` implementations, but it's pure speculation 🔮. On our tests this seems to have fixed the issue, and since it's an equivalent definition of the subscript (even though more "precise" from a generics POV), it should cause no side effects. Fixes pointfreeco#15. 🎉
p4checo
force-pushed
the
bugfix/fix-compiler-crash-on-xcode-11
branch
from
b20f92b
to
9670a49
Compare
|
Well, apparently I got a bit carried away and this only works in an incremental build 😓. Performing a clean build still fails to compile, and running it for the second time also works with the "original" version (i.e. with the Sorry for the noise 😇 |
Apparently by defining `NonEmpty` as conforming to `Collection` right away in its declaration (instead of in an extension), the compilation failure seems to be fixed. Even when performing a clean build, the target now successfully compiles. 🎉 Not sure about the actual cause for this, but this definitely seems like a compiler bug (file ordering / dependency, perhaps?).
|
After much experimentation, I seem to have found a working solution, even for clean builds 🎉 |
|
What's the status of this PR? |
mbrandonw
approved these changes
Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently by defining
NonEmptyas conforming toCollectionright away in its declaration (instead of in an extension), the compilation failure with a weirdDESERIALIZATION FAILUREerror, as mentioned on #15 seems to be fixed.Even when performing a clean build, the target now successfully compiles. 🎉 (it didn't with the previous solution).
Not sure about the actual cause for this, but this definitely seems like a compiler bug (file ordering / dependency, perhaps? 🔮).
Fixes #15. 🎉