-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multiple snapshotting strategy for each assert #150
Conversation
as: [snapshotting], | ||
named: name, | ||
record: recording, | ||
timeout: timeout) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Stephen and I will discuss this sometime soon, but in the meantime there is a quick thing you can do to get tests passing. Make sure to pass along the file
, testName
and line
to the assert snapshot helpers so that files names are recorded properly.
We also prefer to have all the function arguments on a newline if they don't fit on online, as opposed to this hanging argument style.
Also there's an extra image that was added to the repo that could be deleted:
assertSnapshot-matching-as-named-record-timeout-file-testName-line.1.png
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comments, I will do the modification
Hey @mackoj, thanks for the PR! One thing that I think needs to change is that We wrote these helpers in the Point-Free repo awhile back: Feel free to grab em and use em in this PR! Will be happy to merge when you do 😄 And thanks for taking the time to help! |
Oh! And unfortunately we have to define these helpers twice right now (you can scroll above the last link to see them defined inside the Linux |
Ok I will fix it today. Thanks for the comment @stephencelis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Thanks again! 😄 |
Attempt to fix #116