Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow arbitrary distance function #19

Closed
tpoisot opened this issue Dec 7, 2020 · 0 comments
Closed

Allow arbitrary distance function #19

tpoisot opened this issue Dec 7, 2020 · 0 comments
Assignees
@tpoisot
Labels
enhancement New feature or request in-progress
Milestone
v0.0.4

Comments

@tpoisot
Copy link
Member

tpoisot commented Dec 7, 2020

Is your feature request related to a problem? Please describe.
It would be good to allow all distance functions from StringDistances

Describe the solution you'd like
Additional keyword argument to taxid (and namefinder)

Ideally, this can take the form of code you would like to write:

using NCBITaxonomy
taxid("Box turus"; fuzzy=true, d=StringDistances.JaroWinkler)

Additional context
Work ongoing on main.
@tpoisot tpoisot added enhancement New feature or request need-triage labels Dec 7, 2020
@tpoisot tpoisot self-assigned this Dec 7, 2020
@tpoisot tpoisot added this to the v0.0.4 milestone Dec 7, 2020
tpoisot added a commit that referenced this issue Dec 7, 2020
@tpoisot
✨ Closes Allow arbitrary distance function #19
6172f66
@tpoisot tpoisot closed this as completed Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tpoisot tpoisot

Labels
enhancement New feature or request in-progress
Projects
None yet
Milestone
v0.0.4
Development

No branches or pull requests
1 participant
@tpoisot