[BUG] Navigation widget violates layout by setting ward space 'nowrap'

[Mulli]

Description

Navigation widget set the 'a' link to ward-space:nowrap.
This may violate column layout.

As a rule: NO widget is allowed to expand beyond column layout
UNLESS specifically requested by the user.

I suggest to add a style option in the navigation menu to allow nowrap.
The default value should allow wrapping.

Steps to reproduce

Environment

[bainternet]

@Mulli

Can you provide an example of how it violates the layout??

[Mulli]

Hi Ohad Very simple Please look at https://ncr.site2goal.net/data_warehouse_edw_dwh_teradata/ Prior to twicking the CSS the menu items were over the text (in a separate column) to the left. This is what I call layout violation. Since not element in one column should cover another in different column UNLESS I specifically request for it. Therefore I suggest that you make it an *option* for the menu. Keep up the good work! Best Mulli בברכה מולי באהר 050-9262025 <http://site2goal.co.il/> https://facebook.com/site2goal From: raz ohad [mailto:notifications@github.com] Sent: Sunday, November 26, 2017 9:43 AM To: pojome/elementor‏ <elementor@noreply.github.com> Cc: Mulli Bahr‏ <mulli@site2goal.co.il>; Mention‏ <mention@noreply.github.com> Subject: Re: [pojome/elementor] [BUG] Navigation widget violates layout by setting ward space 'nowrap' (#2815) @Mulli <https://github.com/mulli> Can you provide an example of how it violates the layout?? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2815 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AAuu0_jG_4fApvYRpK4I4ki3xx9Sg-DRks5s6RaQgaJpZM4QqT5y> . <https://github.com/notifications/beacon/AAuu0zJsIwrgyhSRR4p0a__v2P7_S7Blks5s6RaQgaJpZM4QqT5y.gif>

[bainternet]

@Mulli

thanks for the reply,
I still can't understand what exactly is the issue here,

Can you provide steps to reproduce?
Also, are you using the "Nav menu" widget? is it a WordPress Menu? or a different plugin??

[bainternet]

@Mulli

Nevermind,

I see what you mean, ( the side menu )...

Well then, in that case, you are correct, We do try to keep our Widgets as generic and customizable as possible and we update and tweak them all the time. so, this feature is not supported, but we will look into it in the future.

Thanks for the suggestion and feedback.

[Mulli]

Hi Ohad My main menu is Ubermenu plugin But the side menu is Elementors menu See the attached image that demonstrate the problem. And below is the css fix (forcing white-space:normal, instead of nowrap) .elementor-nav-menu--main .elementor-nav-menu a { 1. -webkit-transition: .4s; 2. -o-transition: .4s; 3. transition: .4s; 4. white-space: nowrap; } autoptimize_fe5…4612534a.css:5 .elementor-nav-menu--main .elementor-nav-menu a { 1. /* white-space: normal !important; */ } Best Mulli בברכה מולי באהר 050-9262025 <http://site2goal.co.il/> https://facebook.com/site2goal From: raz ohad [mailto:notifications@github.com] Sent: Sunday, November 26, 2017 10:23 AM To: pojome/elementor‏ <elementor@noreply.github.com> Cc: Mulli Bahr‏ <mulli@site2goal.co.il>; Mention‏ <mention@noreply.github.com> Subject: Re: [pojome/elementor] [BUG] Navigation widget violates layout by setting ward space 'nowrap' (#2815) @Mulli <https://github.com/mulli> thanks for the reply, I still can't understand what exactly is the issue here, Can you provide steps to reproduce? Also, are you using the "Nav menu" widget? is it a WordPress Menu? or a different plugin?? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2815 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AAuu02F8LB7Bo7_KwwVNkJ7Ab86iZsDbks5s6R_hgaJpZM4QqT5y> . <https://github.com/notifications/beacon/AAuu0-EX7Pbm0gcurztfnZYhkB27Djpgks5s6R_hgaJpZM4QqT5y.gif>

[bainternet]

@Mulli

Thanks again, Already got that #2815 (comment)

[arielk]

Fix Pro v1.10.2

[Mulli]

Hi Ariel I think this is the right decision. Happy it made its way to the release. I promise to suggest more fixes… Keep up the GOOD job you are doing. Best regards Mulli בברכה מולי באהר 050-9262025 <http://site2goal.co.il/> https://facebook.com/site2goal From: Ariel Klikstein [mailto:notifications@github.com] Sent: Sunday, December 3, 2017 5:29 PM To: pojome/elementor‏ <elementor@noreply.github.com> Cc: Mulli Bahr‏ <mulli@site2goal.co.il>; Mention‏ <mention@noreply.github.com> Subject: Re: [pojome/elementor] [BUG] Navigation widget violates layout by setting ward space 'nowrap' (#2815) Fix Pro v1.10.2 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2815 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AAuu0-wjhrrNTTTe-OG3Tt3LD7lVVq9rks5s8r5GgaJpZM4QqT5y> . <https://github.com/notifications/beacon/AAuu0_tUzNxEgfX3XEbhqGmgkFxC5G-Bks5s8r5GgaJpZM4QqT5y.gif>