Possible memory leak #284
Closed
Possible memory leak #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would like to second this fix; the sslProperties object created if a clientCertificateIdentity is present in the startRequest method creates an autoreleased NSDictionary object, whereas the one created if no valid SSL Certificate is present is not autoreleased. I tested this exact same change here on my side and it worked flawlessly. |
|
Thanks for suggesting this fix - several different fixes for this had built up in the pull queue, so I've applied one and am closing the rest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by static analyzer. Shouldn't break things as much as I've tried.