Giratina Questline

[HyruleTeam64]

Adds a questline for Giratina, focused around finding an entrance to the Distortion World. It is intended to be completed in late Sinnoh.
Also adds the Griseous Orb Held Item. It can be dropped by Giratina Altered and gives it a 50% attack bonus. Giratina Altered can evolve into Giratina Origin by reaching level 70 with the Griseous Orb equipped.

[Farboo171]

A few comments from the devs, relayed here:

• The overall structure of the quest looks good!

• The method for obtaining Giratina-A and O at the end is somewhat inconsistent with the general approach to Legendary quests we're shooting for. Rewarding an already-existing alt form is the main inconsistency

• It would be more in line with other quests if you kept Giratina-A as the boss for Distortion World, replaced the reward stage with a Griseous Orb reward, and made Giratina-O a held item evolution of Giratina-A

• Rather than the TemporaryBattleRequirement('Giratina') quest start requirement, completion of the "A New World" questline is probably more appropriate.

Do these seem like changes you could make?

[Ultima1990]

Rather than the TemporaryBattleRequirement('Giratina') quest start requirement, completion of the "A New World" questline is probably more appropriate.

Keep in mind that for this to work, the new Giratina-A tempbattle has to become part of the "A New World" questline. Which it currently isn't.
Also you'd probably still want the tempbattle requirement anyway, since that way you can guarantee that the player has Giratina-A before starting "Zero's Ambition". Including those playing without the dex challenge. Cuz that just makes sense, you know? You should have a Giratina before you go looking for a way to transform your Giratina.

[HyruleTeam64]

It would be more in line with other quests if you kept Giratina-A as the boss for Distortion World, replaced the reward stage with a Griseous Orb reward, and made Giratina-O a held item evolution of Giratina-A

I'm not sure if I have understood this correctly, should I keep the Giratina temporary battle after A New World and have it give the Orb instead of Giratina-A or remove the battle and give the Griseous Orb during the Giratina quest?

Rather than the TemporaryBattleRequirement('Giratina') quest start requirement, completion of the "A New World" questline is probably more appropriate

I used that requirement because, if players who have beaten Sinnoh completed the quest without beating Giratina, there would be two Distortion Worlds in the map. If I remove the temporary battle requirement, I don't think the A New World one would be required, since you need to have completed the quest in order to beat Cynthia.

I'll change the PR into a draft in order to make all the necessary changes.

[Farboo171]

Keeping the Giratina-A temporary battle is ok. Now that I read the quest steps more closely, I'd say move the Orb to be a reward for beating Zero. You can make the last steps:

1. Beat Zero, which gives you an Orb
2. Catch Giratina-A, who is the boss of Distortion World
3. Evolve Giratina-O using the Orb

As Ultima brought up, the Giratina temporary battle should be part of a quest line. I think adding it to the beginning of this quest would work fine if you don't want to muck around in already finished quests.

[Qwertypop04]

The Giratina O temp battle really needs to be part of "A New World" or to not exist at all. It would be necessary for progression, where this quest would presumably be a quest board questline, and it would be somewhat confusing to have it not be part of A New World when it's required to go to Sunnyshore

[HyruleTeam64]

The Giratina O temp battle really needs to be part of "A New World" or to not exist at all. It would be necessary for progression, where this quest would presumably be a quest board questline, and it would be somewhat confusing to have it not be part of A New World when it's required to go to Sunnyshore

I initially added it outside of A New World so players who have completed A New World but haven't caught Giratina-A could still get it. But if we are doing Giratina-O as a held item evolution, I don't think the Giratina temp battle should exist, since players could still catch Giratina-A as a boss in the Distortion World.

[Qwertypop04]

I initially added it outside of A New World so players who have completed A New World but haven't caught Giratina-A could still get it. But if we are doing Giratina-O as a held item evolution, I don't think the Giratina temp battle should exist, since players could still catch Giratina-A as a boss in the Distortion World.

That makes sense. At this point it has no essential purpose, other than flavour and canon, so including it or not works

[HyruleTeam64]

You can make the last steps:

Beat Zero, which gives you an Orb
Catch Giratina-A, who is the boss of Distortion World
Evolve Giratina-O using the Orb

I think that would be the best way to do it. Giratina-O should probably be a Questline restricted evolution in order to prevent players who already have Giratina from wasting the Orb before catching the Pokemon for the quest.

[Qwertypop04]

I think that would be the best way to do it. Giratina-O should probably be a Questline restricted evolution in order to prevent players who already have Giratina from wasting the Orb before catching the Pokemon for the quest.

Given that the goal of the player during the questline, isn't to obtain Giratina (Origin), but to return to the Distortion World, I don't think that obtaining Giratina-O actually needs to be something required to complete the quest. Maybe it would make sense to have the quest finish upon catching Giratina-A? Then we wouldn't have to give the Griseous Orb for free (could have it be dungeon loot or a drop from Giratina-A?).

[Aegyo]

Mostly just looked over the text for any issues, haven't run the code.

Did you check if adding that bulletin board in the middle causes any problems for old saves?

[HyruleTeam64]

Did you check if adding that bulletin board in the middle causes any problems for old saves?

It didn't cause any problems when I tested it, but I may have missed something.

[Aegyo]

You've got a conflict here because of items moving into modules

[HyruleTeam64]

I've fixed the conflict, thanks for letting me know.

[CorgiOnNeptune]

Commented for two small typos.

[Jaaslet]

Looks good. Thanks for the PR

I have rereviewed it