Docker Image enhancement and better CLI support. #1600
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
A few Geo-Mesh users report to POKTscan about an issue with the new image after we adopt the one on the pokt-network/pocket-core repository on the latest RC.
They report that this image is using
root
as the user and is recommended to avoid that practice. There are a lot of blogs and documentation about this, here one of them from a well-known docker image user/company.Also, we detected a few things that could be enhanced on both, entry point and docker context.
The problem with having a public image using root right now is that pocket binary generates folders and files that now belong to the
root
user, so they will need to modify those permissions to belong to the properapp
user and group. To this, I added another optional entry point that could be used once to fix the permission issue and then start the container as before.Here you can see how to use it with docker-compose or docker
Changes:
app
user instead ofroot
.reviewpad:summary