-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IBC] Create initial IBC module #842
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #842 +/- ##
==========================================
- Coverage 31.52% 31.44% -0.08%
==========================================
Files 107 110 +3
Lines 9034 9190 +156
==========================================
+ Hits 2848 2890 +42
- Misses 5846 5955 +109
- Partials 340 345 +5
☔ View full report in Codecov by Sentry. |
- [Node Configuration](#node-configuration) | ||
- [Components](#components) | ||
- [ICS-24 Host Requirements](#ics-24-host-requirements) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wdyt about adding a persistence (or something) section which covers what network state this module interacts with?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added a brief section to cover this but the rest of the persistence info will come in the ICS-24 Store PR as this is where interfacing with persistence actually comes into play
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Bryan White <bryanchriswhite@gmail.com>
22b48dd
to
d1a4667
Compare
option go_package = "github.com/pokt-network/pocket/runtime/configs"; | ||
|
||
message IBCConfig { | ||
// If IBC is enabled by a node there are two possible states depending on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
f.Add("port") | ||
} | ||
} | ||
f.Fuzz(func(t *testing.T, idType string) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
@@ -0,0 +1,24 @@ | |||
package host |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for splitting these into separate files!
Makes it so much easier to read and understand!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@h5law I know you didn't re-request a review on this but I took another look and thing it's more than good enough.
There are probably some changes we can make, but I don't think anything is a blocker so let's merge it in and iterate on main.
* refactor/unicast-router: fix: return error chore: cleanup unused garbage chore: add missing godoc comments chore: add submodule TECHDEBT comments chore: comment cleanup chore: cleanup unused test utils [IBC] Create initial IBC module (#842) [Persistence] Adds TreeStore logger (#852) [Persistence] Change root hash calculation to use an SMT (#843)
* feat/integrate-bg-router: (21 commits) chore: improve comment' wip: docs: architecture diagrams chore: add TECHDEBT comment Update E2E_FEATURE_LIST.md Update vault_test.go (#862) chore: return early chore: improve debug logging chore: improve comments chore: improve variable naming fix: `p2pModule#Send()` routing logic fix: interim background router bootstrapping chore: router logging improvements fix: return error chore: cleanup unused garbage chore: add missing godoc comments chore: add submodule TECHDEBT comments chore: comment cleanup chore: cleanup unused test utils [IBC] Create initial IBC module (#842) [Persistence] Adds TreeStore logger (#852) ...
…duce-submodule * 'feat/integrate-bg-router' (early part): (21 commits) test: fix raintree message target test [P2P] refactor: unicast router (#844) chore: add TECHDEBT comment Update E2E_FEATURE_LIST.md Update vault_test.go (#862) chore: return early chore: improve debug logging chore: improve comments chore: improve variable naming fix: `p2pModule#Send()` routing logic fix: interim background router bootstrapping chore: router logging improvements fix: return error chore: cleanup unused garbage chore: add missing godoc comments chore: add submodule TECHDEBT comments chore: comment cleanup chore: cleanup unused test utils [IBC] Create initial IBC module (#842) [Persistence] Adds TreeStore logger (#852) ...
Description
This PR introduces the base IBC module and partially implements ICS-24 (paths, keys and identifiers)
Issue
Fixes #794
Type of change
Please mark the relevant option(s):
List of changes
shared/modules/ibc_module.go
shared/core/types/commitments.go
for IBC commitment type aliasesshareds/core/types/errors.go
Testing
make develop_test
; if any code changes were mademake test_e2e
on k8s LocalNet; if any code changes were madee2e-devnet-test
passes tests on DevNet; if any code was changedRequired Checklist
godoc
format comments on touched members (see: tip.golang.org/doc/comment)If Applicable Checklist
shared/docs/*
if I updatedshared/*
README(s)