-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Persistence] Change root hash calculation to use an SMT #843
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## persistence/tree-store #843 +/- ##
==========================================================
- Coverage 30.86% 30.80% -0.06%
==========================================================
Files 108 108
Lines 9228 9264 +36
==========================================================
+ Hits 2848 2854 +6
- Misses 6040 6070 +30
Partials 340 340
☔ View full report in Codecov by Sentry. |
0aa8aad
to
70537ca
Compare
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
5841025 | Generic High Entropy Secret | 690a0ad | charts/pocket/templates/configmap-genesis.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
76b75fb
to
b168429
Compare
* refactor/unicast-router: fix: return error chore: cleanup unused garbage chore: add missing godoc comments chore: add submodule TECHDEBT comments chore: comment cleanup chore: cleanup unused test utils [IBC] Create initial IBC module (#842) [Persistence] Adds TreeStore logger (#852) [Persistence] Change root hash calculation to use an SMT (#843)
Description
Summary generated by Reviewpad on 23 Jun 23 10:35 UTC
This pull request contains several file diffs with various updates and additions. The implementation of the
setupTrees
function inmodule.go
has been updated to use a newstateTree
struct and additional error handling. ThePocket V1
protocol state hash document has been updated with changes to various infrastructural components and the computation of the state hash. Thepersistence_module.go
file has a newGetTreeStore()
method, andtreestore_module.go
file has a new import statement andGetTree()
function. Additionally, theutility/session_test.go
andstate.go
test cases have been updated with new values and logic changes.Issue
Fixes #834
Type of change
Please mark the relevant option(s):
List of changes
Testing
make develop_test
; if any code changes were mademake test_e2e
on k8s LocalNet; if any code changes were madee2e-devnet-test
passes tests on DevNet; if any code was changedRequired Checklist
godoc
format comments on touched members (see: tip.golang.org/doc/comment)If Applicable Checklist
shared/docs/*
if I updatedshared/*
README(s)