Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IBC] chore: enable IBC module in k8s validators #941

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Conversation

h5law
Copy link
Contributor

@h5law h5law commented Jul 26, 2023

Description

Summary generated by Reviewpad on 26 Jul 23 22:08 UTC

This pull request includes two commits.

The first commit enables the IBC module in the k8s validators. It adds new configurations for the IBC module and sets it to enabled. It also specifies the stores directory and the private key for the host.

The second commit adds generated helm documentation to the pocket charts. It modifies the README.md file to include documentation for the configuration settings related to the IBC module.

Overall, these changes enable the IBC module in k8s validators and provide documentation for it in the helm charts.

Issue

Fixes N/A

Type of change

Please mark the relevant option(s):

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Major breaking change
  • Documentation
  • Other

List of changes

  • Enable IBC module in k8s validators

Testing

  • make develop_test; if any code changes were made
  • make test_e2e on k8s LocalNet; if any code changes were made
  • e2e-devnet-test passes tests on DevNet; if any code was changed
  • Docker Compose LocalNet; if any major functionality was changed or introduced
  • k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
  • I have tested my changes using the available tooling
  • I have updated the corresponding CHANGELOG

If Applicable Checklist

  • I have updated the corresponding README(s); local and/or global
  • I have added tests that prove my fix is effective or that my feature works
  • I have added, or updated, mermaid.js diagrams in the corresponding README(s)
  • I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@h5law h5law added e2e-devnet-test Runs E2E tests on devnet ibc IBC specific changes labels Jul 26, 2023
@h5law h5law added this to the M7: Pocket NoS (North Star) milestone Jul 26, 2023
@h5law h5law requested review from Olshansk and okdas July 26, 2023 22:07
@h5law h5law self-assigned this Jul 26, 2023
@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jul 26, 2023
@h5law h5law merged commit a0fb2ce into main Jul 27, 2023
2 checks passed
@h5law h5law deleted the ibc/enable_in_k8s branch July 27, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e-devnet-test Runs E2E tests on devnet ibc IBC specific changes small Pull request is small waiting-for-review
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants