fix: Finish adding typed_lit to help schema determination in SQL "e…

…xtract" func (#15955)
pola-rs · Apr 30, 2024 · 9c96dca · 9c96dca
1 parent f0dbb6a
commit 9c96dca
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/crates/polars-sql/src/sql_expr.rs b/crates/polars-sql/src/sql_expr.rs
@@ -997,11 +997,11 @@ fn parse_extract(expr: Expr, field: &DateTimeField) -> PolarsResult<Expr> {
         DateTimeField::Minute => expr.dt().minute(),
         DateTimeField::Second => expr.dt().second(),
         DateTimeField::Millisecond | DateTimeField::Milliseconds => {
-            (expr.clone().dt().second() * lit(1_000))
+            (expr.clone().dt().second() * typed_lit(1_000f64))
                 + expr.dt().nanosecond().div(typed_lit(1_000_000f64))
         },
         DateTimeField::Microsecond | DateTimeField::Microseconds => {
-            (expr.clone().dt().second() * lit(1_000_000))
+            (expr.clone().dt().second() * typed_lit(1_000_000f64))
                 + expr.dt().nanosecond().div(typed_lit(1_000f64))
         },
         DateTimeField::Nanosecond | DateTimeField::Nanoseconds => {

diff --git a/py-polars/tests/unit/sql/test_temporal.py b/py-polars/tests/unit/sql/test_temporal.py
@@ -86,7 +86,6 @@ def test_datetime_to_time(time_unit: Literal["ns", "us", "ms"]) -> None:
         ),
     ],
 )
-@pytest.mark.skip(reason="don't understand; will ask @alex")
 def test_extract(part: str, dtype: pl.DataType, expected: list[Any]) -> None:
     df = pl.DataFrame(
         {