Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Finish adding typed_lit to help schema determination in SQL "extract" func #15955

Merged
merged 1 commit into from Apr 30, 2024

Conversation

alexander-beedie
Copy link
Collaborator

@alexander-beedie alexander-beedie commented Apr 29, 2024

@ritchie46: here you go ;)

(Otherwise it seems the dt.second op can overflow int8 during scaling and wrap around to odd values; not immediately obvious why it decided to do this now vs earlier, but the solution is straightforward).

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Apr 29, 2024
@alexander-beedie alexander-beedie added the A-sql Area: Polars SQL functionality label Apr 29, 2024
@ritchie46
Copy link
Member

Thanks!

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.33%. Comparing base (f0dbb6a) to head (dee9355).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15955      +/-   ##
==========================================
+ Coverage   81.29%   81.33%   +0.04%     
==========================================
  Files        1381     1381              
  Lines      176876   176876              
  Branches     3043     3043              
==========================================
+ Hits       143789   143860      +71     
+ Misses      32604    32532      -72     
- Partials      483      484       +1     
Flag Coverage Δ
python 74.78% <100.00%> (+0.04%) ⬆️
rust 78.45% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 9c96dca into pola-rs:main Apr 30, 2024
31 checks passed
@alexander-beedie alexander-beedie deleted the sql-extract-schema-fix branch April 30, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sql Area: Polars SQL functionality fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants