Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add graphviz in the list of optional dependencies #12477

Closed
gab23r opened this issue Nov 15, 2023 · 2 comments · Fixed by #15791
Closed

Add graphviz in the list of optional dependencies #12477

gab23r opened this issue Nov 15, 2023 · 2 comments · Fixed by #15791
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@gab23r
Copy link
Contributor

gab23r commented Nov 15, 2023

Description

I don't know if the list of dependencies in the readme is supposed to be exhaustive. In that case graphviz is missing from the list

pl.LazyFrame().show_graph()
# ImportError: Graphviz dot binary should be on your PATH

Link

No response
@gab23r gab23r added the documentation Improvements or additions to documentation label Nov 15, 2023
@gab23r gab23r changed the title Add graphviz in the list of optinal dependencies Add graphviz in the list of optionaldependencies Nov 15, 2023
@gab23r gab23r changed the title Add graphviz in the list of optionaldependencies Add graphviz in the list of optional dependencies Nov 15, 2023
@universalmind303 universalmind303 added the good first issue Good for newcomers label Dec 11, 2023
@sky-2002
Copy link

@universalmind303 Shoud this be added to this file or where?

This was referenced Apr 18, 2024
Closed
Merged
@alexander-beedie
Copy link
Collaborator

alexander-beedie commented Apr 22, 2024 •
edited

Note that the Python graphviz package does not install the required binary; it only helps you construct "dot" files. It's not a dependency of Polars as we construct those files ourselves, and adding it wouldn't help.

See: https://graphviz.org/download/

  • Mac: brew install graphviz
  • Linux: sudo apt install graphviz
  • Windows: download a suitable binary from the link above.

@NexVeridian has a PR incoming that makes the error/info message a little clearer here, providing the download link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
4 participants
@alexander-beedie @universalmind303 @sky-2002 @gab23r