Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add graphviz in the list of optional dependencies #15755

Closed
wants to merge 0 commits into from
Closed

Add graphviz in the list of optional dependencies #15755

wants to merge 0 commits into from

Conversation

NexVeridian
Copy link
Contributor

closes #12477

Add graphviz in the list of optional dependencies

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.35%. Comparing base (96e1f01) to head (1ee5a7e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15755   +/-   ##
=======================================
  Coverage   81.35%   81.35%           
=======================================
  Files        1379     1379           
  Lines      176603   176603           
  Branches     2544     2544           
=======================================
+ Hits       143677   143682    +5     
+ Misses      32443    32438    -5     
  Partials      483      483           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@alexander-beedie alexander-beedie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NexVeridian; thanks for the PR, but I don't think this fixes the linked issue. The graphviz Python package doesn't actually install the underlying graphviz dot executable (rather, that package helps you to create "dot" files, but the executable still needs to be separately installed to render them; as we create the "dot" file ourselves, we don't need that package to be present).

We can probably improve the docs and/or error by more explicitly pointing to the graphviz install page; would you like to amend the PR (or submit a new one) to try that instead? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add graphviz in the list of optional dependencies
2 participants