docs(python): improve graphviz install documentation/error message #15791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NexVeridian
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15791 +/- ##
==========================================
- Coverage 81.35% 80.38% -0.97%
==========================================
Files 1379 1263 -116
Lines 176603 165351 -11252
Branches 2544 0 -2544
==========================================
- Hits 143677 132923 -10754
+ Misses 32443 32428 -15
+ Partials 483 0 -483 ☔ View full report in Codecov by Sentry. |
alexander-beedie
force-pushed
the
graphviz-install-documentation
branch
from
fba3b29
to
1340234
Compare
|
Yep, this looks good to me; I slightly tweaked the error/info message (added the Sphinx docs URL format to the link so it becomes clickable in the docs). Thanks! |
alexander-beedie
approved these changes
Apr 22, 2024
alexander-beedie
changed the title
github-actions
bot
added
documentation
stinodego
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #15755 and maybe closes #12477
Adds links pointing to graphviz install page, let me know if I should change anything