-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Allow broadcasting in ranges
#11900
Merged
Merged
Changes from 16 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
5393cdd
Add tests
stinodego 236bf63
Fix broadcasting
stinodego 6ba2648
Add test for mismatched chunks
stinodego 9582ea2
Add test for failure condition
stinodego 621da58
Formatting
stinodego 99e30b3
Clean up util
stinodego 9054b5e
WIP
stinodego 5ac2526
Broadcast util
stinodego 8918140
Update datetime
stinodego aad43a3
Update closure signature
stinodego aaa5c22
Update types
stinodego e2acec6
Update date_ranges
stinodego 23619a3
Update int ranges
stinodego 9978423
Simplify int_ranges capacity
stinodego 482aaa8
Get rid of unsafe
stinodego 79fdc5b
Use repeat
stinodego 8a31029
No zip import
stinodego 5bdca6b
Generic iterators
stinodego 4baefd9
Use std::iter::repeat directly
stinodego 9e0c13c
Use downcast iter flatten
stinodego File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this pass and set a default capacity of 5 times the length of the column, similar to the other
ranges
functions. If this capacity calculation must be preserved, I have to make some adjustments as it relied on fully materializing start/end.