fix(python): Revert type hint change on expression inputs #12792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stinodego
requested review from
ritchie46,
alexander-beedie and
MarcoGorelli
as code owners
alexander-beedie
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12782
Reverts the type hint change in #12709
This change basically meant that type hinting was disabled for anyone that did not have NumPy installed, as
np.ndarrayis treated asAny.I am not sure what the best way to go about this is, but I'd rather have some false positives on NumPy inputs (that you can mute by wrapping with
lit) than no type hinting at all. We can revisit this at a later point.