Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(python): Mark whether the current package is the LTS-CPU version #13068

Merged
merged 3 commits into from
Dec 18, 2023

Conversation

stinodego
Copy link
Member

It's a bit hacky, but this should do the job...

@orlp does this give you what you need?

@github-actions github-actions bot added build Changes that affect the build system or external dependencies python Related to Python Polars labels Dec 16, 2023
@orlp
Copy link
Collaborator

orlp commented Dec 16, 2023

Yes, that should help. Perhaps the filename should be something more descriptive than _build.py though.

@stinodego stinodego marked this pull request as ready for review December 16, 2023 17:48
@stinodego
Copy link
Member Author

stinodego commented Dec 16, 2023

Yes, that should help. Perhaps the filename should be something more descriptive than _build.py though.

I assume you're going to include the vendored code for determining instruction sets in this module? Maybe it should be _cpu_check.py? Suggestions welcome.

I'm also fine with merging this and renaming it to something else when you add the actual implementation.

@orlp orlp merged commit 3f03873 into main Dec 18, 2023
14 checks passed
@orlp orlp deleted the lts-flag branch December 18, 2023 15:06
@c-peters c-peters added the accepted Ready for implementation label Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation build Changes that affect the build system or external dependencies python Related to Python Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants