fix(python): Correctly use read_parquet for all binary inputs
#13218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stinodego
commented
Dec 23, 2023
| @@ -145,7 +145,7 @@ def read_parquet( | |||
| ) | |||
|
|
|||
| # Read binary types using `read_parquet` | |||
| elif isinstance(source, (BinaryIO, BytesIO, bytes)): | |||
| elif isinstance(source, (io.BufferedIOBase, io.RawIOBase, bytes)): | |||
There was a problem hiding this comment.
This was the culprit - it didn't catch files opened in binary mode.
There was a problem hiding this comment.
Alright. Nice to have it covered in tests now. :) Would have never seen that in a review. :D
There was a problem hiding this comment.
Yeah this stuff is mighty confusing with the type hints vs the objects and everything named similarly.
I'm definitely doing more refactoring around the IO functions soon, lots of improvements to be made here.
stinodego
force-pushed
the
read-parquet
branch
from
dc0aa32
to
ef4db2d
Compare
stinodego
requested review from
alexander-beedie and
MarcoGorelli
as code owners
ritchie46
approved these changes
Dec 23, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13099