fix(python): make read_parquet() respect rechunk flag when using pyarrow #16418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16418 +/- ##
==========================================
- Coverage 81.43% 81.43% -0.01%
==========================================
Files 1409 1409
Lines 184567 184567
Branches 2962 2962
==========================================
- Hits 150305 150299 -6
- Misses 33746 33752 +6
Partials 516 516 ☔ View full report in Codecov by Sentry. |
itamarst
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
ritchie46
approved these changes
May 23, 2024
Wouittone
pushed a commit
to Wouittone/polars
that referenced
this pull request
Jun 22, 2024
…row (pola-rs#16418) Co-authored-by: Itamar Turner-Trauring <itamar@pythonspeed.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16416
While playing around with measuring memory I also discovered rechunk() doesn't release the GIL, so I fixed that too while I was at it.