fix: Arguments for upsample only have to be sorted within groups
#18264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case of `group_by` being provide as an extra argument to `upsample`, the index needs to be only sorted within those groups.
thomascamminady
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
github-actions
bot
added
fix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18264 +/- ##
=======================================
Coverage 80.21% 80.22%
=======================================
Files 1500 1500
Lines 198897 198897
Branches 2837 2837
=======================================
+ Hits 159547 159566 +19
+ Misses 38822 38803 -19
Partials 528 528 ☔ View full report in Codecov by Sentry. |
Simplify the testing for the newly added tests to only test newly added functionality.
crates/polars-time/src/upsample.rs
Outdated
Comment on lines
124
to
126
| s.ensure_sorted_arg("upsample")?; | ||
| if by.is_empty() { | ||
| s.ensure_sorted_arg("upsample")?; | ||
| } |
There was a problem hiding this comment.
thanks for your PR!
does it work to move this check into upsample_single_impl?
There was a problem hiding this comment.
Thanks! That was indeed the cleaner way to do it.
…ork_if_args_are_sorted_within_group
thomascamminady
deleted the
feature/Issue18229_upsample_should_work_if_args_are_sorted_within_group
branch
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of
group_bybeing provide as an extra argument toupsample, the index needs to be only sorted within those groups. This tries to fix the issue observed in #18229.Tests are added to check that
Note, this is my first commit and I am not a Rust developer.