Improve parse_lines error message. #3569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve parse_lines error message:
- Fix file offset at which the error was encountered
(header and skipped lines were not included).
- Remove leading spaces in error message due to use
of raw string.
- Add other ideas (specify correct dtype or increasing
number of records used to infer the schema) to
potentionaly avoid the error, as the error also show
up quite frequently when an incorrect dtype was
inferred.
Previous error message:
ComputeError: Could not parse 3.0 as dtype Int64 at column 3.
The total offset in the file is 37 bytes.
Consider running the parser `with_ignore_parser_errors=true`
or consider adding 3.0 to the `null_values` list.
Current error message:
ComputeError: Could not parse `3.0` as dtype Int64 at column 3.
The current offset in the file is 69 bytes.
Consider specifying the correct dtype, increasing
the number of records used to infer the schema,
running the parser with `ignore_parser_errors=true`
or adding `3.0` to the `null_values` list.
Codecov Report
@@ Coverage Diff @@
## master #3569 +/- ##
===========================================
- Coverage 77.62% 61.56% -16.07%
===========================================
Files 425 424 -1
Lines 71364 71065 -299
===========================================
- Hits 55396 43749 -11647
- Misses 15968 27316 +11348
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve parse_lines error message:
(header and skipped lines were not included).
of raw string.
number of records used to infer the schema) to
potentionaly avoid the error, as the error also show
up quite frequently when an incorrect dtype was
inferred.
Previous error message:
ComputeError: Could not parse 3.0 as dtype Int64 at column 3.
The total offset in the file is 37 bytes.
Current error message:
ComputeError: Could not parse
3.0as dtype Int64 at column 3.The current offset in the file is 69 bytes.
Consider specifying the correct dtype, increasing
the number of records used to infer the schema,
running the parser with
ignore_parser_errors=trueor adding
3.0to thenull_valueslist.