feat!: add simd feature and remove polars/simd from the default f…

…eature (#262)

.github/workflows/check.yaml

@@ -12,6 +12,9 @@ concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
   cancel-in-progress: true
 
+env:
+  RPOLARS_ALL_FEATURES: "true"
+
 jobs:
   R-CMD-check:
     runs-on: ${{ matrix.config.os }}

.github/workflows/docs.yaml

@@ -20,6 +20,9 @@ concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
   cancel-in-progress: true
 
+env:
+  RPOLARS_ALL_FEATURES: "true"
+
 jobs:
   documentation:
     runs-on: ubuntu-latest

.github/workflows/release.yaml

@@ -13,6 +13,9 @@ concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
   cancel-in-progress: true
 
+env:
+  RPOLARS_ALL_FEATURES: "true"
+
 jobs:
   build:
     runs-on: ${{ matrix.config.os }}

NEWS.md

@@ -8,6 +8,8 @@ for demonstration purposes (#240).
 - Polars is internally moving away from string errors to a new error-type called `RPolarsErr` both on rust- and R-side. Final error messages should look very similar (#233).
 - LazyFrame_columns, _schema, _dtypes implemented. Improvements to internal `RPolarsErr`. Also `RPolarsErr` will now print each context of the error on a separate line (#250).
 - Add helpful reference landing page at `polars.github.io/reference_home` (#223, #264).
+- rust-polars' `simd` feature is now disabled by default. To enable it, set the environment variable
+  `RPOLARS_ALL_FEATURES` to `true` when build r-polars (#262).
 - `select()` now accepts lists of expressions. For example, `<DataFrame>$select(l_expr)`
   works with `l_expr = list(pl$col("a"))` (#265).
 

src/Makevars

@@ -1,3 +1,5 @@
+BUILD_COMMAND = cargo build --lib --release --manifest-path="$(RPOLARS_RUST_SOURCE)/Cargo.toml"
+
 LIBDIR = ./rust/target/release
 STATLIB = $(LIBDIR)/libr_polars.a
 PKG_LIBS = -L$(LIBDIR) -lr_polars
@@ -10,7 +12,11 @@ all: C_clean
 $(SHLIB): $(STATLIB)
 
 $(STATLIB):
-	cargo build --lib --release --manifest-path="$(RPOLARS_RUST_SOURCE)/Cargo.toml"
+	if [ "$(RPOLARS_ALL_FEATURES)" == "true" ]; then \
+		$(BUILD_COMMAND) --all-features; \
+	else \
+		$(BUILD_COMMAND); \
+	fi;
 	if [ -f "$(STATLIB)" ]; then \
 		echo "file is there: "; \
 	else \

src/Makevars.win

@@ -1,4 +1,5 @@
 TARGET = $(subst 64,x86_64,$(subst 32,i686,$(WIN)))-pc-windows-gnu
+BUILD_COMMAND = cargo build --target=$(TARGET) --lib --release --manifest-path="$(RPOLARS_RUST_SOURCE)/Cargo.toml"
 
 TARGET_DIR = ./rust/target
 LIBDIR = $(TARGET_DIR)/$(TARGET)/release
@@ -20,7 +21,11 @@ $(STATLIB):
 	echo "RPOLARS_RUST_SOURCE is set to $(RPOLARS_RUST_SOURCE)"
 	export CARGO_TARGET_X86_64_PC_WINDOWS_GNU_LINKER="$(CARGO_LINKER)" && \
 		export LIBRARY_PATH="$${LIBRARY_PATH};$(CURDIR)/$(TARGET_DIR)/libgcc_mock" && \
-		cargo build --target=$(TARGET) --lib --release --manifest-path="$(RPOLARS_RUST_SOURCE)/Cargo.toml"
+		if [ "$(RPOLARS_ALL_FEATURES)" == "true" ]; then \
+			$(BUILD_COMMAND) --all-features; \
+		else \
+			$(BUILD_COMMAND); \
+		fi;
 
 	# when RPOLARS_RUST_SOURCE is defined rust binary is compiled there
 	# if binary is not here, it can be symlinked instead.

src/rust/Cargo.toml

@@ -1,11 +1,14 @@
 [package]
-name = 'r-polars'   # r-polars
+name = 'r-polars' # r-polars
 version = '0.1.0' # this version no is not used
 edition = '2021'
 
-
 [lib]
-crate-type = [ 'staticlib' ]
+crate-type = ['staticlib']
+
+[features]
+default = []
+simd = ["polars/simd"]
 
 [workspace]
 # prevents package from thinking it's in the workspace
@@ -16,7 +19,9 @@ mimalloc = { version = "0.1.34", default-features = false }
 jemallocator = { version = "0.5.0", features = ["disable_initial_exec_tls"] }
 
 [dependencies]
-extendr-api = {git = "https://github.com/rpolars/extendr", branch = "errorhandling", default-features = false, features= ["result_list"]}
+extendr-api = { git = "https://github.com/rpolars/extendr", branch = "errorhandling", default-features = false, features = [
+  "result_list",
+] }
 #extendr-api = {path = "../../../extendr/extendr-api", default-features = false, features= ["result_list"]}
 
 flume = "0.10.14"
@@ -26,7 +31,7 @@ smartstring = "1.0.1"
 serde_json = "*"
 thiserror = "1.0.40"
 indenter = "0.3.3"
-polars-core = {git = "https://github.com/pola-rs/polars.git",  rev = "e973f6386a28f16136fb8ba5a737103f95911861", default_features= false}
+polars-core = { git = "https://github.com/pola-rs/polars.git", rev = "e973f6386a28f16136fb8ba5a737103f95911861", default_features = false }
 
 
 #try to trigger new hashFiles hash value
@@ -39,7 +44,6 @@ features = [
   "json",
   "dynamic_groupby",
   "zip_with",
-  "simd",
   "lazy",
   "strings",
   "temporal",
@@ -121,7 +125,7 @@ features = [
   "string_from_radix",
   "meta",
   "approx_unique",
-  ]
+]
 default-features = false
 git = "https://github.com/pola-rs/polars.git"
 rev = "e973f6386a28f16136fb8ba5a737103f95911861"