Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename subnamespace Expr.arr to .list #230

Closed
sorhawell opened this issue Jun 2, 2023 · 4 comments
Closed

rename subnamespace Expr.arr to .list #230

sorhawell opened this issue Jun 2, 2023 · 4 comments

Comments

@sorhawell
Copy link
Collaborator

pola-rs/polars#8999

@sorhawell sorhawell changed the title rename subnamespace Expr.arr to `.list| rename subnamespace Expr.arr to `.list Jun 2, 2023
@sorhawell sorhawell changed the title rename subnamespace Expr.arr to `.list rename subnamespace Expr.arr to .list Jun 2, 2023
@eitsupi eitsupi linked a pull request Jul 2, 2023 that will close this issue
@eitsupi eitsupi removed a link to a pull request Jul 4, 2023
@eitsupi eitsupi mentioned this issue Jul 4, 2023
@etiennebacher
Copy link
Collaborator

etiennebacher commented Sep 6, 2023

This has to be done at some point but it would bloat the code to keep both arr and list namespaces. I think we can replace all arr by list at once, which will be a massive breaking change. That could be worth a new release (maybe 0.8.1?).

What do you think @sorhawell @eitsupi ? I can deal with that if you agree

@sorhawell
Copy link
Collaborator Author

The subnamespaces can be moved around relatively easy. I can start a community PR with the namespace rerouting

Maybe the complete change could be done in two PRs

Patch update to 0.8.1 or so

  • reroute arr subnamespace from Expr$arr to also Expr$list (~5 lines of r code)
  • update docs to recommend list over arr + deprecation warning on arr (many search replace, but hopefully fast)

Minor update to 0.9 maybe

  • close Expr$arr access
  • rename internally to remove mentions of arr

@etiennebacher
Copy link
Collaborator

Sounds good to me. I think we could release 0.8.1 right after your "rerouting" PR and then take more time until 0.9.0 so that the deprecation notice is visible to the users at least for a few weeks

@etiennebacher
Copy link
Collaborator

arr is now deprecated and will be removed in 0.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants