-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: bump rust-polars to 0.30.0 #289
Conversation
The errors in Rust have been fixed but have not yet passed the R tests. |
I think this should close #230 |
I fixed as many of the test failures as I could. The remaining failures are a problem where |
Thanks. I will take a look at it. |
I was just looking at this myself and Python's |
I found polars did a behavior change on date_range such that it produces Eager = False a list of DateRanges. |
Oh, thank you for finding that. The change definitely makes sense, but we cannot incorporate that change here because it has not yet been made in the main branch. |
One timezone error remaining and the we have restored previous behavior. We can update the date_range(s) behavior in a new PR after this has merged |
tiny detail for reference "fix subtle typo bug" is an incorrect commit msg. There was a unrelated subtle bug (high/low) which did not show, and then I disabled a test on timezone until a future refactor. |
All tests now pass; I would like to defer the renaming from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for updating this. It's fine for me to do all the renaming from arr
to list
in a separate PR, are you also ok with this @sorhawell ?
@@ -706,20 +700,20 @@ ExprStr_slice = function(offset, length = NULL) { | |||
unwrap("in str$slice:") | |||
} | |||
|
|||
#' explode | |||
#' @name ExprStr_explode | |||
#' str_explode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be better to have a proper title here (not just for this function)
Co-authored-by: Etienne Bacher <52219252+etiennebacher@users.noreply.github.com>
@etiennebacher Thanks for your review. Since this PR contains updates to the toolchain and everything needs to be recompiled every time we switch branches, I think it's better to merge it in sooner rather than later, so I'm merging it. |
Co-authored-by: sorhawell <sorhawell@gmail.com> Co-authored-by: Etienne Bacher <52219252+etiennebacher@users.noreply.github.com>
https://github.com/pola-rs/polars/releases/tag/rs-0.29.0
https://github.com/pola-rs/polars/releases/tag/rs-0.30.0