Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add simd feature and remove polars/simd from the default feature #262

Merged
merged 8 commits into from
Jun 29, 2023

Conversation

eitsupi
Copy link
Collaborator

@eitsupi eitsupi commented Jun 27, 2023

Related to #80 and #90

Enable/disable simd by environment variable at build time.
simd is disabled by default for CRAN releases.

@eitsupi eitsupi requested a review from sorhawell June 27, 2023 13:47
@eitsupi eitsupi marked this pull request as ready for review June 27, 2023 13:48
@eitsupi eitsupi added this to the 1st CRAN Release milestone Jun 27, 2023
@eitsupi eitsupi changed the title feat!: add simd feature feat!: add simd feature and remove polars/simd from the default Jun 27, 2023
@eitsupi eitsupi changed the title feat!: add simd feature and remove polars/simd from the default feat!: add simd feature and remove polars/simd from the default feature Jun 27, 2023
@sorhawell sorhawell mentioned this pull request Jun 27, 2023
@eitsupi eitsupi mentioned this pull request Jun 28, 2023
@eitsupi
Copy link
Collaborator Author

eitsupi commented Jun 28, 2023

After this merged, I want to switch the R-universe source to the main branch.

NEWS.md Show resolved Hide resolved
@eitsupi
Copy link
Collaborator Author

eitsupi commented Jun 28, 2023

@sorhawell Could you take a look at this?

Copy link
Collaborator

@sorhawell sorhawell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome thanks :)

@eitsupi eitsupi merged commit 7be27be into pola-rs:main Jun 29, 2023
8 checks passed
@eitsupi eitsupi deleted the simd-feature branch June 29, 2023 00:05
@eitsupi
Copy link
Collaborator Author

eitsupi commented Jun 29, 2023

Thank you for your review!

This was referenced Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants