fix!: change the default delimiter of $str$concat from "-" to "" and ignore_nulls should be a named argument
#853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will update after merging #852 |
eitsupi
force-pushed
the
change-delim-concat
branch
from
1a3b230
to
b9e7e97
Compare
eitsupi
changed the title
$str$concat from "-" to ""$str$concat from "-" to ""
eitsupi
changed the title
$str$concat from "-" to ""$str$concat from "-" to "" and ignore_nulls should be a named argument
etiennebacher
requested changes
Feb 27, 2024
Comment on lines
+18
to
+19
| - `<Expr>$str$concat()` method's `delimiter` argument's default value is | ||
| changed from `"-"` to `""` (#853). |
There was a problem hiding this comment.
Should this be deprecated instead?
There was a problem hiding this comment.
I would like to change now as it is too much of a hassle to split the update into two separate updates.
…ignore_nulls` should be named argument
Co-authored-by: Etienne Bacher <52219252+etiennebacher@users.noreply.github.com>
eitsupi
force-pushed
the
change-delim-concat
branch
from
ab2e880
to
0d3ba75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref pola-rs/polars#13690