-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: updated some functions to be equivalent to Python Polars #852
Conversation
Oops, I didn't realize that |
I thought this for a moment, but then I realized that enforcing a character vector is not a bad thing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, nice refactor again
@@ -232,7 +232,7 @@ ExprStr_len_chars = function() { | |||
#' | |||
#' # Series list of strings to Series of concatenated strings | |||
#' df = pl$DataFrame(list(bar = list(c("a", "b", "c"), c("1", "2", NA)))) | |||
#' df$select(pl$col("bar")$list$eval(pl$col()$str$concat())$list$first()) | |||
#' df$select(pl$col("bar")$list$eval(pl$col("")$str$concat("-"))$list$first()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python will raise a warning if the concat()
argument is missing. I will update that with another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #853
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @eitsupi
No description provided.