feat: support remove config changeListener #79
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
chuntaojun
reviewed
Jul 20, 2022
确实两个场景差异不大，感觉可以考虑标记下弃用。 |
看看是否可以单独提交一个ISSUE以及PR，把这个chan形式的监听移除？ |
chuntaojun
previously approved these changes
Jul 20, 2022
好的，我看下。 |
|
这么测试结果怎么看😂，好长。 |
lepdou
previously approved these changes
Jul 21, 2022
|
其他应该没什么问题，辛苦补一个单元测试吧 |
|
单元测试我要看下哦，之前配置貌似都没有单元测试。 |
|
我先熟悉下这个测试包，这个跑得有点慢😂 |
|
弃用提示也加上了，打开goland发现一个拼写错误，实在抱歉。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide issue(s) of this PR:
Fixes #73
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.
Please check any characteristics that apply to this pull request.