Upgrade Node.js to 20, relax engines requirements, update CI #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a library, we shouldn't require an exact version but rather tell the oldest supported one and update the minimum as required. Also, no real need to required npm 9 specifically.
|
Minor enough and cinode-bot need these, so I'll just merge once CI works again and passes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to the latest Node.js LTS version, 20 -- mainly a formality for development purposes.
But mainly, relax the
enginesrequirements: as a library, we shouldn't be too strict about the Node.js and npm version our users have but rather define the supported minimum version and bump it when necessary. We can define a maximum if a breaking change appears later on, but eschew it for now.Also update GitHub Actions to their latest versions, so that they also use Node.js 20 and simplify CI by using
.nvmrcas the source of truth for CI's Node.js version instead of maintaining it separately (no more forgetting to update CI).