Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Update README with latest help text, remove smoothing disclaimer #119

Merged
merged 4 commits into from Mar 4, 2019

Conversation

kfinc
Copy link
Contributor

@kfinc kfinc commented Mar 4, 2019

Included optional smoothing in README. Removed info about not supporting smoothing.

Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. It looks like there are spacing issues; I assume you ran fitlins --help from the terminal, copied and and then your editor changed spaces to tabs or similar on paste. If it's not easy to ensure literal copies, I can rerun it for you.

README.rst Outdated
It is developed against `FMRIPREP`_-preprocessed datasets, but is intended to
work with any dataset following the `BIDS Derivatives`_ draft specification.
At present, FitLins does not operate in subject-native space. It is developed against `FMRIPREP`_-preprocessed datasets,
but is intended to work with any dataset following the `BIDS Derivatives`_ draft specification.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just modify the first sentence? I use newlines after each sentence to reduce the diff when sentence length cascades to line changes, as it does here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! How about now?

@effigies effigies changed the title Adding smoothing to README.rst DOC: Update README with latest help text, remove smoothing disclaimer Mar 4, 2019
@effigies effigies merged commit ca40343 into poldracklab:master Mar 4, 2019
@effigies
Copy link
Collaborator

effigies commented Mar 4, 2019

Thanks. It turned out there were a few things in the help that hadn't been updated lately, so I went ahead and re-run fitlins --help and copied the result into the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants