-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Don't validate generated paths #180
FIX: Don't validate generated paths #180
Conversation
Damn. The pypi upload is still broken. Trying to upload from my laptop, but it's crawling. |
That sucks. Well none of this is urgent. I opened in a separate PR given that I assumed it would be blocked for a while. |
Tethered to my phone just to get things moving. 0.9.4 is up. |
Codecov Report
@@ Coverage Diff @@
## master #180 +/- ##
=========================================
Coverage ? 76.42%
=========================================
Files ? 17
Lines ? 984
Branches ? 171
=========================================
Hits ? 752
Misses ? 146
Partials ? 86
Continue to review full report at Codecov.
|
65a521f
to
5a4e98c
Compare
@effigies this is good to go |
Merging, as I need it the other PR. |
Fixes #179
Need to wait on pybids release so that Circle pulls the new version of pybids that causes this problem.
Also depends on #178 which has other fixes.