Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Don't validate generated paths #180

Merged
merged 6 commits into from Sep 20, 2019

Conversation

adelavega
Copy link
Collaborator

Fixes #179

Need to wait on pybids release so that Circle pulls the new version of pybids that causes this problem.
Also depends on #178 which has other fixes.

@effigies
Copy link
Collaborator

Damn. The pypi upload is still broken. Trying to upload from my laptop, but it's crawling.

@adelavega
Copy link
Collaborator Author

That sucks. Well none of this is urgent. I opened in a separate PR given that I assumed it would be blocked for a while.

@effigies
Copy link
Collaborator

Tethered to my phone just to get things moving. 0.9.4 is up.

@codecov-io
Copy link

codecov-io commented Sep 20, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@8b2eccf). Click here to learn what that means.
The diff coverage is 45.45%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #180   +/-   ##
=========================================
  Coverage          ?   76.42%           
=========================================
  Files             ?       17           
  Lines             ?      984           
  Branches          ?      171           
=========================================
  Hits              ?      752           
  Misses            ?      146           
  Partials          ?       86
Flag Coverage Δ
#ds003 76.42% <45.45%> (?)
Impacted Files Coverage Δ
fitlins/viz/reports.py 89.06% <100%> (ø)
fitlins/interfaces/bids.py 73.57% <40%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b2eccf...5a4e98c. Read the comment docs.

adelavega added a commit to adelavega/fitlins that referenced this pull request Sep 20, 2019
@adelavega
Copy link
Collaborator Author

@effigies this is good to go

@adelavega
Copy link
Collaborator Author

Merging, as I need it the other PR.

@adelavega adelavega merged commit 86c1043 into poldracklab:master Sep 20, 2019
@adelavega adelavega deleted the fix/build_path_validate branch September 20, 2019 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueError: Built path is not a valid BIDS filename.
3 participants