Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Set smoothing_fwhm after creating next level. Fixes #189 #190

Merged
merged 1 commit into from Oct 2, 2019

Conversation

adelavega
Copy link
Collaborator

Fixes #189

The smoothing_fwhm was applied to model before the next level's model was created. This resulted in the Subject level inputs being smoothing rather than Dataset

@effigies
Copy link
Collaborator

effigies commented Oct 2, 2019

Feel free to merge when tests pass.

@adelavega
Copy link
Collaborator Author

Cool. Unfortunately looking at the git blame here, I can't find any scapegoats for this one.

@codecov-io
Copy link

codecov-io commented Oct 2, 2019

Codecov Report

Merging #190 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #190   +/-   ##
======================================
  Coverage    76.4%   76.4%           
======================================
  Files          18      18           
  Lines        1017    1017           
  Branches      177     177           
======================================
  Hits          777     777           
  Misses        150     150           
  Partials       90      90
Flag Coverage Δ
#ds003 76.4% <0%> (ø) ⬆️
Impacted Files Coverage Δ
fitlins/workflows/base.py 60.43% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a937444...1f682a8. Read the comment docs.

@adelavega adelavega merged commit 5e707c6 into poldracklab:master Oct 2, 2019
@adelavega adelavega deleted the fix/smoothing_level branch October 2, 2019 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Smoothing is being applied at previous level
3 participants