Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BIDSelect confusion between Nifti and JSON #193

Merged
merged 2 commits into from Oct 15, 2019

Conversation

adelavega
Copy link
Collaborator

Fixes #192

@codecov-io
Copy link

codecov-io commented Oct 11, 2019

Codecov Report

Merging #193 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #193   +/-   ##
======================================
  Coverage    76.4%   76.4%           
======================================
  Files          18      18           
  Lines        1017    1017           
  Branches      177     177           
======================================
  Hits          777     777           
  Misses        150     150           
  Partials       90      90
Flag Coverage Δ
#ds003 76.4% <ø> (ø) ⬆️
Impacted Files Coverage Δ
fitlins/workflows/base.py 60.43% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e707c6...7a77c3d. Read the comment docs.

@effigies
Copy link
Collaborator

Should probably allow .nii as well.

@effigies
Copy link
Collaborator

What about .gii?

@adelavega
Copy link
Collaborator Author

adelavega commented Oct 14, 2019

Sure, why not? Too bad we can't say "not JSON"

@effigies effigies merged commit 3976e36 into poldracklab:master Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

non-unique error-- bold nifti confused with json
3 participants