Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Migrate CircleCI to github actions #329

Merged
merged 35 commits into from
Jan 18, 2022
Merged

ENH: Migrate CircleCI to github actions #329

merged 35 commits into from
Jan 18, 2022

Conversation

shashankbansal6
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2022

Codecov Report

Merging #329 (8d56b9c) into master (277c27f) will decrease coverage by 14.11%.
The diff coverage is 55.08%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #329       +/-   ##
===========================================
- Coverage   78.58%   64.46%   -14.12%     
===========================================
  Files          23       23               
  Lines        1793     1818       +25     
  Branches      284      281        -3     
===========================================
- Hits         1409     1172      -237     
- Misses        264      565      +301     
+ Partials      120       81       -39     
Flag Coverage Δ
afni_blurto ?
afni_smooth ?
database-file ?
nistats_blurto ?
nistats_smooth ?
pytest 64.46% <55.08%> (-0.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
fitlins/__init__.py 76.47% <ø> (ø)
fitlins/__main__.py 0.00% <ø> (ø)
fitlins/cli/run.py 0.00% <0.00%> (-81.03%) ⬇️
fitlins/conftest.py 100.00% <ø> (ø)
fitlins/utils/bids.py 0.00% <0.00%> (-52.86%) ⬇️
fitlins/utils/config.py 100.00% <ø> (ø)
fitlins/viz/reports.py 0.00% <0.00%> (-90.15%) ⬇️
fitlins/interfaces/visualizations.py 57.59% <61.36%> (-3.35%) ⬇️
fitlins/workflows/base.py 58.77% <77.08%> (-16.93%) ⬇️
fitlins/interfaces/nistats.py 72.34% <81.25%> (+2.11%) ⬆️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f6cea2...8d56b9c. Read the comment docs.

Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Some small comments. I'm also going to try to replace your neurodocker.sh with an updated .neurodocker.json.

.github/workflows/workflows.yml Outdated Show resolved Hide resolved
.github/workflows/workflows.yml Outdated Show resolved Hide resolved
.github/workflows/workflows.yml Outdated Show resolved Hide resolved
.zenodo.json Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
Co-authored-by: Chris Markiewicz <markiewicz@stanford.edu>
Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can try removing build_docs and test the RTD PR builds now.

.github/workflows/workflows.yml Outdated Show resolved Hide resolved
.github/workflows/workflows.yml Outdated Show resolved Hide resolved
@shashankbansal6
Copy link
Collaborator Author

Overall looks good. Some small comments. I'm also going to try to replace your neurodocker.sh with an updated .neurodocker.json.

Yeah I was actually going to ask you to do this. Some of the stuff those neurodocker files are sort of patch-work so they definitely need your inputs.

@effigies effigies merged commit f29fbd4 into master Jan 18, 2022
@effigies effigies deleted the pr/actions branch January 18, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants