-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Migrate CircleCI to github actions #329
Conversation
…tional checks/tests for deploy_pypi
Codecov Report
@@ Coverage Diff @@
## master #329 +/- ##
===========================================
- Coverage 78.58% 64.46% -14.12%
===========================================
Files 23 23
Lines 1793 1818 +25
Branches 284 281 -3
===========================================
- Hits 1409 1172 -237
- Misses 264 565 +301
+ Partials 120 81 -39
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
a940867
to
b76b076
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Some small comments. I'm also going to try to replace your neurodocker.sh
with an updated .neurodocker.json
.
Co-authored-by: Chris Markiewicz <markiewicz@stanford.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can try removing build_docs
and test the RTD PR builds now.
Yeah I was actually going to ask you to do this. Some of the stuff those neurodocker files are sort of patch-work so they definitely need your inputs. |
No description provided.