Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: Simplify entry-points, restore preproc discovery #38

Merged
merged 7 commits into from
May 23, 2018

Conversation

effigies
Copy link
Collaborator

This places sys.exit in the main entry-point, to reduce the chance of unexpected exits for any external calling code.

This also restores preproc discovery, prioritizing that found in <bids_dir>/derivatives.

Other minor simplifications were also applied, such as allowing argparse to apply os.path.abspath to file inputs.

Closes #32
Closes #34

@effigies effigies requested a review from adelavega May 22, 2018 19:37
@effigies
Copy link
Collaborator Author

@adelavega This doesn't need thorough review; just want to make sure that it doesn't break things for you.

@adelavega
Copy link
Collaborator

Yep, I know. I just won't get a chance to test that until tomorrow.

@effigies
Copy link
Collaborator Author

Cool. No rush.

@effigies
Copy link
Collaborator Author

I was able to run your models all the way through. I had fmriprep in the output directory, but that shouldn't make a difference at this point. Merging.

@effigies effigies merged commit 1017bbd into poldracklab:master May 23, 2018
@effigies effigies deleted the rf/cli branch May 23, 2018 18:57
@adelavega
Copy link
Collaborator

ok cool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants