-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Limit NaN imputation and use mean non-zero value #57
Conversation
👌 |
My PR is merged. Oh by the way, maybe it's not a bad idea to warn users (or throw an exception) if |
Actually, do we even want to by-default impute any but the expected And to complicate matters further, non-steady-state volumes will push down the "first" volume. |
I agree. I just think a nice exception would be nice to have. |
Looks like fMRIPrep does not remove non-steady-state volumes before calculating FD/DVARS, so we don't actually need to account for that. (The nistats interface will need to zero them out, but we should already be doing that.)
|
Okay. Modulo some prettifying CSS, this is working for me. @adelavega do you want to give it a shot? |
can you do a release/push to docker hub? it'll make it easier for me to test |
So how does it actually get run for you? Do you call |
I extend your build with a Dockerfile: https://github.com/neuroscout/neuroscout-cli/blob/master/Dockerfile (just realized I may be re-installing |
0.0.5 is on Docker Hub. |
Cheers |
Fixes #56.