-
-
Notifications
You must be signed in to change notification settings - Fork 282
from_sbdb unit tests fails with default installation #861
Comments
from_sbdb
unit tests fails with default installation
Started to work on this. Previously ran this in v0.13 (the one currently installed in conda). Ran again with the current version on the github (0.14) and found a similar issue. For clarity, Failing line:
Right now, the current entry on the JPL SBDB is:
🔦 What I think the problem is:
|
You're totally right @iMurfyD: this test is fragile because it depends on the latest data from JPL. So I see a few ways of fixing it:
What do you think? |
I didn't see an obvious way to download an "old" ephemerides. I can see the upsides and downsides to each of these. Alternatively, I tried to write a test which compares the I think comparing the two databases to each other would be the best idea since we maintain that we are trying to use the networking features of the method and are doing some type of comparison to make sure the thing which is downloaded and parsed into the software is more or less the right orbit. Another option might be to manually scrape the website for the orbital elements and compare against that - although I'm not sure how different (and hence useful) that is from the actual implementation of the |
Implemented a unit test that cross references databases and submitted as a pull request: |
Whoops :/ |
Fixed in #867! |
🐞 Problem
🖥 Please paste the output of following commands
conda info -a
(only if you have conda)conda list
(only if you have conda)pip freeze
💡 Possible solutions
It looks like the SBDB entry for Ceres doesn't match the hard-coded value in the unit test (from the test failing) - in this case the inclination specifically. Check the source and make sure that the hard coded value in the unit test is actually the orbit of Ceres
📋 Steps to solve the problem
Addresses #<put issue number here>
The text was updated successfully, but these errors were encountered: