Skip to content
This repository has been archived by the owner on Oct 14, 2023. It is now read-only.

Support for Azure Pipelines #846

Merged
merged 4 commits into from
Mar 17, 2020
Merged

Support for Azure Pipelines #846

merged 4 commits into from
Mar 17, 2020

Conversation

jains8844
Copy link
Contributor

In reference to #822

Some changes are required like endpoint, build_url and also triggers.

@astrojuanlu
Copy link
Member

Thanks @jains8844 for doing this work! This would close #664 and #822.

Some changes are required like endpoint, build_url and also triggers.

Do we need to do anything from the project side?

@jains8844
Copy link
Contributor Author

Do we need to do anything from the project side?

Yeah

  1. The BUILD_URL will change according to the pipeline you will set up.
  2. Same thing to the endpoint.
  3. Triggers refer to which branches and which tags to include and exclude and how to trigger the CI.

@jains8844
Copy link
Contributor Author

Also what about the failing tests @Juanlu001 ?

@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #846 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #846   +/-   ##
=======================================
  Coverage   89.25%   89.25%           
=======================================
  Files          65       65           
  Lines        3164     3164           
  Branches      266      266           
=======================================
  Hits         2824     2824           
  Misses        273      273           
  Partials       67       67

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66b8cf5...c0ab69d. Read the comment docs.

@astrojuanlu
Copy link
Member

@astrojuanlu
Copy link
Member

@jains8844 I propose we remove the image tests from Windows and macOS. I proposed it at the beginning but it was a bad idea, I'm sure they're failing because of typography and stuff like that.

@jains8844
Copy link
Contributor Author

Sure sir

@jains8844
Copy link
Contributor Author

All the tests passed :)

@jains8844
Copy link
Contributor Author

I think we should have online tests too for certain platform.
Also regarding the online tests, I ran pytest -vvv --remote-data=any test_orbit.py::test_from_sbdb.
This test fails with this.

@jains8844
Copy link
Contributor Author

Any review for this 😅

@astrojuanlu
Copy link
Member

Sorry @jains8844, I need to find the time to create the project in Azure pipelines. Hopefully today or tomorrow.

@astrojuanlu
Copy link
Member

Also regarding the online tests, I ran pytest -vvv --remote-data=any test_orbit.py::test_from_sbdb.
This test fails with this.

Hmm can you add them as well? I lost count of how many jobs we have so far, but perhaps it's not an issue if we have more than 10?

@jains8844
Copy link
Contributor Author

Okay sure :)

@jains8844
Copy link
Contributor Author

jains8844 commented Mar 2, 2020

Also regarding the online tests, I ran pytest -vvv --remote-data=any test_orbit.py::test_from_sbdb.
This test fails with this.

Hmm can you add them as well? I lost count of how many jobs we have so far, but perhaps it's not an issue if we have more than 10?

Yeah no issue but one will be pending till one of the other finishes.

@astrojuanlu
Copy link
Member

Getting to this ~ soon ~ 💪

Please be ready to rebase

@jains8844
Copy link
Contributor Author

jains8844 commented Mar 15, 2020

Aye sir!

@astrojuanlu
Copy link
Member

Please rebase!

@jains8844 jains8844 force-pushed the azure branch 2 times, most recently from a841ce6 to 98eba15 Compare March 15, 2020 20:14
@jains8844
Copy link
Contributor Author

Done!

@astrojuanlu
Copy link
Member

@astrojuanlu
Copy link
Member

Screenshot_2020-03-17 New pipeline - Pipelines

😒

@astrojuanlu
Copy link
Member

IT'S ALIIIIIIIVEEEEEEEEEEEEEE

@astrojuanlu
Copy link
Member

I see one test failing on Windows with:

This probably means that Tcl wasn't installed properly

The one failing on Linux is #861.

...I am merging anyway 😈 And let's fix them afterwards!

@astrojuanlu astrojuanlu merged commit 563808d into poliastro:master Mar 17, 2020
@astrojuanlu
Copy link
Member

Thanks a lot @jains8844! ❤️

@jains8844
Copy link
Contributor Author

That was fast :o

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants