-
-
Notifications
You must be signed in to change notification settings - Fork 282
Conversation
Thanks @jains8844 for doing this work! This would close #664 and #822.
Do we need to do anything from the project side? |
Yeah
|
Also what about the failing tests @Juanlu001 ? |
Codecov Report
@@ Coverage Diff @@
## master #846 +/- ##
=======================================
Coverage 89.25% 89.25%
=======================================
Files 65 65
Lines 3164 3164
Branches 266 266
=======================================
Hits 2824 2824
Misses 273 273
Partials 67 67 Continue to review full report at Codecov.
|
Current test results: https://dev.azure.com/jains8844/sample-proj/_build/results?buildId=22&view=results |
@jains8844 I propose we remove the image tests from Windows and macOS. I proposed it at the beginning but it was a bad idea, I'm sure they're failing because of typography and stuff like that. |
Sure sir |
All the tests passed :) |
I think we should have online tests too for certain platform. |
Any review for this 😅 |
Sorry @jains8844, I need to find the time to create the project in Azure pipelines. Hopefully today or tomorrow. |
Hmm can you add them as well? I lost count of how many jobs we have so far, but perhaps it's not an issue if we have more than 10? |
Okay sure :) |
Yeah no issue but one will be pending till one of the other finishes. |
Getting to this ~ soon ~ 💪 Please be ready to rebase |
Aye sir! |
Please rebase! |
a841ce6
to
98eba15
Compare
Done! |
IT'S ALIIIIIIIVEEEEEEEEEEEEEE |
I see one test failing on Windows with:
The one failing on Linux is #861. ...I am merging anyway 😈 And let's fix them afterwards! |
Thanks a lot @jains8844! ❤️ |
That was fast :o |
In reference to #822
Some changes are required like endpoint, build_url and also triggers.