This repository has been archived by the owner on Oct 14, 2023. It is now read-only.
Add regression tests for propagation and sampling #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
nikita-astronaut
approved these changes
Mar 1, 2018
| assert_quantity_allclose(iss.raan, res.raan) | ||
| assert_quantity_allclose(iss.argp, res.argp) | ||
|
|
||
| assert_quantity_allclose((res.epoch - iss.epoch).to(time_of_flight.unit), time_of_flight) |
There was a problem hiding this comment.
Looks like a great idea to test this
|
Awesome! I will merge as soon as the CI is happy. |
Codecov Report
@@ Coverage Diff @@
## master #331 +/- ##
==========================================
+ Coverage 80.61% 80.88% +0.27%
==========================================
Files 30 30
Lines 1465 1465
Branches 114 114
==========================================
+ Hits 1181 1185 +4
+ Misses 252 250 -2
+ Partials 32 30 -2
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #265 definitively. We now have a way to track which methods work and which don't. I'm very happy that we finally have this working.
@nikita-astronaut as author of #322, do you want to review this?