This repository has been archived by the owner on Oct 14, 2023. It is now read-only.
Frames improvements #446
Merged
Frames improvements #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the need to manually set the frame for ecliptic orbits and offers a simple way to change the reference frame without knowing everything.
ghost
assigned 
|
Perturbation tests are failing probably because I changed the Moon frame back to GCRS. |
This somehow reverts poliastro#312 while offering a solution for poliastro#287, paving the way for returning the velocity (see poliastro#380), and offering a warning related to poliastro#445.
Codecov Report
@@ Coverage Diff @@
## master #446 +/- ##
==========================================
- Coverage 85.76% 85.49% -0.27%
==========================================
Files 47 47
Lines 2086 2096 +10
Branches 162 161 -1
==========================================
+ Hits 1789 1792 +3
- Misses 258 263 +5
- Partials 39 41 +2
Continue to review full report at Codecov.
|
|
I ran out of time to do the rest before the beta, so I'm merging this! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Orbitconstructors to allow different plane and improve the experience for ecliptic orbitsrepresent_as, see Orbital state, longitude and latitude #442 (comment)Make plotter objects at least give a warning if the frames are inconsistentMake creating objects from aCartesianRepresentationmuch easier, see https://nbviewer.jupyter.org/github/poliastro/poliastro/blob/f32050a82/docs/source/examples/Analyzing%20the%20Parker%20Solar%20Probe%20flybys.ipynb#5.-Exit-orbitThings that we will not do:
Orbit.transform_to(frame): it will have to wait until we have proper checks for propagationOrbit.rv()return aCartesianRepresentationwith differentialsOrbit.coe()