Add new setting to disable the classloading cache #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uschindler
changed the title
Conflicts: src/main/java/de/thetaphi/forbiddenapis/ant/AntTask.java
Conflicts: src/main/java/de/thetaphi/forbiddenapis/maven/AbstractCheckMojo.java
|
I just checked this again with 2.13 and the problem still exists, and this PR does indeed workaround the issue. |
| @@ -23,10 +23,19 @@ if (project.plugins.withType(JavaBasePlugin.class).isEmpty()) { | |||
| throw new PluginInstantiationException('Forbidden-apis only works in projects using the java plugin.'); | |||
| } | |||
|
|
|||
| // chck if running in Gradle Daemon? | |||
| // see: http://stackoverflow.com/questions/23265217/how-to-know-whether-you-are-running-inside-a-gradle-daemon | |||
| boolean isGradleDaemon = System.getProperty('sun.java.command', '').startsWith('org.gradle.launcher.daemon.') || | |||
There was a problem hiding this comment.
Have you checked this in any other JVMs like openjdk or ibm?
There was a problem hiding this comment.
The second part with stack trace should hit on any JVM. The first check is just a shortcut.
|
The new changes LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #75