Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend index comments #61

Merged
merged 9 commits into from
Oct 7, 2015
Merged

Extend index comments #61

merged 9 commits into from
Oct 7, 2015

Conversation

slomo
Copy link
Contributor

@slomo slomo commented Oct 6, 2015

Extend the indexing of objects to also include comments. Will be used to display how many comments have been given for a specific element.

@slomo
Copy link
Contributor Author

slomo commented Oct 6, 2015

@nidico could you please review 8346eec and @smouzakitis could you please review the other commits, I rearrange the code quite a bit.

@nidico
Copy link
Member

nidico commented Oct 6, 2015

8346eec LGTM.

@cbotsikas
Copy link
Member

@slomo, i'll check this out and come back with comments

Currently stage version of adhocracy doesn't handle the comment count request properly leading to a 200 HTML response which is causing an exception
cbotsikas added a commit that referenced this pull request Oct 7, 2015
Extend index comments
Merged commits are part of policycompass/policycompass#84 resolution.
@cbotsikas cbotsikas merged commit 9a48c1b into master Oct 7, 2015
@cbotsikas
Copy link
Member

This PR is part of policycompass/policycompass#84 resolution.

@nidico nidico deleted the extend-index-comments branch October 7, 2015 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants