-

polina-c · Apr 26, 2024 · bbbe855 · bbbe855
1 parent d8a61c5
commit bbbe855
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 11 deletions.
diff --git a/packages/devtools_app/lib/src/screens/memory/framework/memory_controller.dart b/packages/devtools_app/lib/src/screens/memory/framework/memory_controller.dart
@@ -35,7 +35,6 @@ class MemoryController extends DisposableController
     @visibleForTesting DiffPaneController? connectedDiff,
     @visibleForTesting ProfilePaneController? connectedProfile,
   }) {
-    print('!!!!!!!!! creating MemoryController');
     if (connectedDiff != null || connectedProfile != null) {
       _mode = DevToolsMode.connected;
     } else {

diff --git a/...ges/devtools_app/lib/src/screens/memory/panes/chart/controller/chart_pane_controller.dart b/...ges/devtools_app/lib/src/screens/memory/panes/chart/controller/chart_pane_controller.dart
@@ -50,6 +50,7 @@ class MemoryChartPaneController extends DisposableController
     } else {
       assert(offlineData!.isDeviceAndroid != null);
       data = offlineData!;
+      _paused.value = false;
       recomputeChartData();
     }
 
@@ -65,14 +66,7 @@ class MemoryChartPaneController extends DisposableController
       () => unawaited(_onChartVisibilityChanged()),
     );
 
-    if (mode == DevToolsMode.offlineData) {
-      _paused.value = false;
-      // data.timeline.notifyAboutAllSamples();
-      recomputeChartData();
-      print('!!! sent notifyAboutAllSamples and recomputeChartData');
-    }
     _initialized.complete();
-    print('!!! MemoryChartPaneController init');
   }
 
   late final EventChartController event =

diff --git a/...ls_app/lib/src/screens/memory/panes/chart/controller/charts/android_chart_controller.dart b/...ls_app/lib/src/screens/memory/panes/chart/controller/charts/android_chart_controller.dart
@@ -34,7 +34,6 @@ class AndroidChartController extends ChartController {
           name: 'Android',
           sharedLabelTimestamps: sharedLabels,
         ) {
-    _setupTraces();
     setupData();
 
     addAutoDisposeListener(memoryTimeline.sampleAdded, () {
@@ -52,6 +51,7 @@ class AndroidChartController extends ChartController {
   /// Preload any existing data collected but not in the chart.
   @override
   void setupData() {
+    _setupTraces();
     // Only display if traces have been created. Android memory may not
     // have been toggled to be displayed - yet.
     if (traces.isNotEmpty) {

diff --git a/...ools_app/lib/src/screens/memory/panes/chart/controller/charts/event_chart_controller.dart b/...ools_app/lib/src/screens/memory/panes/chart/controller/charts/event_chart_controller.dart
@@ -59,7 +59,6 @@ class EventChartController extends ChartController {
           displayXLabels: false,
           name: 'Event Pane',
         ) {
-    _setupTraces();
     setFixedYRange(_Sizes.visibleVm, _Sizes.extensions);
     setupData();
 
@@ -75,6 +74,7 @@ class EventChartController extends ChartController {
 
   @override
   void setupData() {
+    _setupTraces();
     final chartDataLength = timestampsLength;
     final dataLength = memoryTimeline.data.length;
 

diff --git a/...evtools_app/lib/src/screens/memory/panes/chart/controller/charts/vm_chart_controller.dart b/...evtools_app/lib/src/screens/memory/panes/chart/controller/charts/vm_chart_controller.dart
@@ -27,7 +27,6 @@ class _Colors {
 class VMChartController extends ChartController {
   VMChartController(this.memoryTimeline, {required this.paused})
       : super(name: 'VM Memory') {
-    _setupTraces();
     setupData();
 
     addAutoDisposeListener(memoryTimeline.sampleAdded, () {
@@ -42,6 +41,7 @@ class VMChartController extends ChartController {
 
   @override
   void setupData() {
+    _setupTraces();
     final chartDataLength = timestampsLength;
     final dataLength = memoryTimeline.data.length;