Skip to content
This repository has been archived by the owner on Aug 7, 2022. It is now read-only.

How to find a new maintainer? #659

Closed
sje30 opened this issue Feb 10, 2021 · 15 comments
Closed

How to find a new maintainer? #659

sje30 opened this issue Feb 10, 2021 · 15 comments

Comments

@sje30
Copy link

sje30 commented Feb 10, 2021

@politza has done an amazing job on this package pdf-tools. It is part of my daily Emacs setup, and probably used by many others. It would be a shame to see it accrue issues and PRs that cannot be shared. I understand others have reached out to @politza but have not heard back.

This reddit thread summarises the state of play:

https://www.reddit.com/r/emacs/comments/ip17pu/looking_for_a_maintainer_for_pdftoolstablist/

Can we as a community agree how best to support this package if @politza no longer has the energy?

Some options (not exclusive)

  1. I'd be willing to ask on the gnu-emacs-devel mailing list for help on maintaining it; I doubt it would get into Emacs core, as much as I would like to see it, because of external dependencies (and possibly copyleft assignments?)

  2. Fork it to melpa/emacsorphanage

  3. Someone volunteer to fork it and maintain

For my part, I don't have time to maintain it, but I could do 2 if that met with everyone's approval.

Stephen

@antoine-levitt
Copy link

The best scenario would be to have @politza add someone as maintainer, but he appears to be unreachable. I'm not sure 1. is the best option, there's little point in moving things to emacs core.

If somebody here steps up as maintainer, is it possible to fork pdf-tools and make MELPA point to the fork? That would probably be the best option.

@sje30
Copy link
Author

sje30 commented Feb 10, 2021

@purcell might be able to address the MELPA issue.

@vedang
Copy link

vedang commented Feb 10, 2021

I'm willing to step up as a maintainer here, I can currently dedicate my weekends for this work. Caveats:

  1. I have not maintained heavily used open-source stuff earlier
  2. I have not contributed to pdf-tools or libpoppler previously. I use pdf-tools mainly to read papers and capture notes (via org-noter). I don't have expertise in PDF land. I can learn though.
  3. I am a long-time Emacs user (14 years) and have written emacs-lisp for my own purposes, but have not written packages / serious emacs-lisp code before. I can learn though.

Let me know if this works, and I will start from this weekend.

@antoine-levitt
Copy link

Has anyone tried to contact politza through something else than github and reddit? There is an Andreas Politz working in IT on LinkedIn and on facebook, but I'm not sure it's him.

@antoine-levitt
Copy link

Hm no it's probably not him, listed university doesn't match with the one in the pdf-tools docs, which someone says has used to try to contact him without success. So dead end it appears...

@sje30
Copy link
Author

sje30 commented Feb 13, 2021

hi @vedang

as no-one else seems keen to rush up, and no-one opposes a fork, why not give it a go and see how you get on? If I can help out, time-willing, I will. Perhaps the starting point would be to get some recent issues folded in, which at the least should start to generate some discussion with the submitters of those issues. Other people who have then expressed interest can join in.

@vedang
Copy link

vedang commented Feb 13, 2021

Sure, I'll get started by reviewing all the issues + PRs and applying the simpler patches. I'll spend some time familiarizing myself with the code as well. The fork is here, https://github.com/vedang/pdf-tools . I'll post some sort of updates from the next weekend onward

@purcell
Copy link
Contributor

purcell commented Feb 15, 2021

listed university doesn't match with the one in the pdf-tools docs, which someone says has used to try to contact him without success.

Is that the trade school email address in this commit? https://github.com/politza/pdf-tools/commit/cc29d4c9c2d81fcb1255f7172fd5b9b7851d656c.patch

@antoine-levitt
Copy link

I imagine they tried the one at the top of the lisp file, this one could be another one to test!

@sje30
Copy link
Author

sje30 commented Feb 15, 2021

has anyone written to this new (Hochschule) email? If not, I can.

@sje30
Copy link
Author

sje30 commented Feb 15, 2021

oh no... both that new email that @purcell found and the one in the .el files bounced when I just tried to send a message.

@vedang
Copy link

vedang commented Feb 21, 2021

Update for weekend 1:

I've reviewed all the PRs and have applied all the simpler patches. For the pending ones, I'll need to set up better testing environments and/or understand the code changes better.

I've merged in patches that close the following PRs and Issues: #539, #578, #591, #658, #590, #650, #649, #604, #660, #588, #626, #631, #589, #566, #628, #567. If the respective authors could close the PRs/Issues, that would be very helpful.

(Since I'm only looking at PRs right now, I'm sure a bunch more issues have been resolved in these patches as well)

I'll see how it goes over the next two weekends and if I feel like I can keep this up, I'll put in a request to point package managers to my fork.

Cheers,
Vedang

@sje30
Copy link
Author

sje30 commented Apr 4, 2021

Thank you Vedang. I have now switched over to your fork using this recipe:

(straight-use-package
 '(pdf-tools :type git
	     :host github :repo "vedang/pdf-tools"))
(pdf-tools-install)

Are you hoping to continue working on this fork?

@vedang
Copy link

vedang commented Apr 5, 2021

Yes @sje30 : I'm continuing working on the fork. Currently, I'm only working on merging in patches / debugging new issues filed by users, but I soon hope to make time for some improvements I've identified and for addressing existing issues. It'll be slow going but I'm in it for the long run.

Thanks for switching over. Doom Emacs has moved over as well, and I'm hoping that slowly everyone else will.

@sje30
Copy link
Author

sje30 commented Apr 5, 2021

Thank you for your continuing hard work!

vedang added a commit to vedang/melpa that referenced this issue May 11, 2021
Hello all,

I've taken over maintainership of the `pdf-tools` package, as
described in politza/pdf-tools#659. This commit changes the MELPA
recipe to use my fork of the package.

Thanks!
Vedang

Closes vedang/pdf-tools#10
tarsius added a commit to emacsmirror/epkgs that referenced this issue May 13, 2021
freebsd-git pushed a commit to freebsd/freebsd-ports that referenced this issue Jun 3, 2021
Discussions about the fork and new maintenance:
politza/pdf-tools#659
mbakke pushed a commit to guix-mirror/guix that referenced this issue Jul 1, 2021
* gnu/packages/emacs-xyz.scm (emacs-pdf-tools): Update.
[source]: Change URL to for.  See
<politza/pdf-tools#659>.

This update is required to make pdf-tools work properly for HiDPI screens.

Signed-off-by: Nicolas Goaziou <mail@nicolasgoaziou.fr>
@politza politza closed this as completed Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants