Fix "undefined function" errors with native-comp

[flatwhatson]

This solves an error that arises from compiling pdf-tools. The pdf-view-current-page macro isn't visible in pdf-cache.el, so the compiler assumes it's a function to be defined later. We then get an error about undefined function every time pdf-cache--prefetch-start is called.

I took the "nuclear" approach of solving this by moving the macros from pdf-view.el out into their own file, though it may be solvable with some more careful re-shuffling if you prefer.

[spacekitteh]

@politza ?

[tmalsburg]

My understanding is that native compilation should be completely transparent. Doesn't this issue suggest a problem with native-comp that should be fixed there?

[flatwhatson]

It's not specific to native-comp, it's actually a byte-compilation error (reported as a warning) which is exposed by native-comp. It's easy to reproduce by byte-compiling that file on its own:

$ emacs --batch -L lisp -f batch-byte-compile lisp/pdf-cache.el

In end of data:
lisp/pdf-cache.el:457:1: Warning: the following functions are not known to be
    defined: pdf-view-current-page, pdf-view-use-scaling-p,
    pdf-view-create-page, pdf-view-desired-image-size

[vedang]

Hey @flatwhatson,

I'm working on merging these changes in. Moving the macros to their own file makes sense to me. One thing you missed was removing / updating the declare-function calls that have been used to inform code where these macros are defined. I'm pushing that change in a different commit.

As for the rest of the byte-compilation warnings, I have added this as a task on my todo list (to check byte-compilation warnings and fix them where possible)

Thanks!

[vedang]

Hey @flatwhatson,

I've merged this PR into vedang/pdf-tools@master . Thank you for submitting this change!

[seagle0128]

Hi, May I know the status of this PR? I am experiencing the same issue.

[vedang]

Hi Vincent, This repo - `politza/pdf-tools` - is unmaintained and no new commits will be merged into it. I am maintaining `pdf-tools` now, at vedang/pdf-tools and this issue has been fixed there. Please switch to that repository, thanks!

…

On Sun, Apr 25, 2021, 1:34 PM Vincent Zhang ***@***.***> wrote: Hi, May I know the status of this PR? I am experiencing the same issue. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#588 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAUUHVYZ3GIWUQI3ZYOI3LTKPEJNANCNFSM4NLNHFRA> .

[seagle0128]

@vedang thank you for letting me know. And I'm happy there is someone to maintain pdf-tools. But it seems MELPA still uses this repo. Can you please confirm and update melpa accordingly? Thanks a lot!

[vedang]

Yup, I need to go through the process of updating MELPA, I'll do that soon :)

…

On Sun, Apr 25, 2021, 9:20 PM Vincent Zhang ***@***.***> wrote: @vedang <https://github.com/vedang> thank you for letting me know. And I'm happy there is someone to maintain pdf-tools. But it seems MELPA still uses this repo. Can you please confirm and update melpa accordingly? Thanks a lot! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#588 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAUUHS7SPQ34CLA6NXGT5LTKQ247ANCNFSM4NLNHFRA> .

[vedang]

Update - MELPA now points to vedang/pdf-tools . @flatwhatson, if you can close this PR, that will be great.

[flatwhatson]

Great, thanks :)